-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Enable logging of metrics from Callbacks to ConsoleLogging #1884
Conversation
Discussed offline, we're going to remove the trainer arg and that arg to the ConsoleLogger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer to @abhi-mosaic for approval to verify this solves his issue, but lgtm
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
I sent Abhi a console log output from a mosaicml/examples GPT run and he confirmed over DM that it looks good. |
What does this PR do?
Sample output from examples repo llm/main.py run:
What issue(s) does this change relate to?
fix CO-1636