Add multi-gpu testing to test_algorithm_resumption #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
approved these changes
Mar 1, 2023
Co-authored-by: nik-mosaic <101217697+nik-mosaic@users.noreply.github.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resuming some model-surgery algorithms using DDP in multi-gpu settings can cause issues due to module renaming.
There is a unit test (
test_algorithm_resumption.py::test_algorithm_resumption) that checks for every algorithm whether you can train a model with that algorithm, save a checkpoint, then resume the training from that checkpoint with the algorithm. However, that unit test only checks when using one gpu.In this PR, we:
test_algorithm_resumption.py::test_algorithm_resumptionto include a 2 gpu setting.algorithm_settings.get_alg_dataloaderto include support for distributed samplersWhat issue(s) does this change relate to?
fix CO-1848