Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gate the extra forward call specifically for fsdp #2102

Merged
merged 2 commits into from
Mar 28, 2023
Merged

gate the extra forward call specifically for fsdp #2102

merged 2 commits into from
Mar 28, 2023

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Mar 28, 2023 •
edited
Loading

What does this PR do?

This PR gates the extra forward call to get generate to work with fsdp on the model actually being fsdp so it is not called when not necessary.

What issue(s) does this change relate to?

N/A

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review March 28, 2023 21:09
@dakinggg dakinggg requested a review from a team as a code owner March 28, 2023 21:09
@dakinggg dakinggg requested a review from dskhudia March 28, 2023 21:09
@dakinggg dakinggg enabled auto-merge (squash) March 28, 2023 21:09
@dakinggg dakinggg disabled auto-merge March 28, 2023 21:09
bcui19
bcui19 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@bcui19 bcui19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dakinggg dakinggg merged commit 3efbd31 into mosaicml:dev Mar 28, 2023
@dakinggg dakinggg deleted the gate_fsdp_generate branch August 8, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcui19 bcui19 bcui19 approved these changes

@dskhudia dskhudia dskhudia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @bcui19 @dskhudia