Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monolithic loading improvements #2313

Merged
merged 26 commits into from
Jun 18, 2023
Merged

Monolithic loading improvements #2313

merged 26 commits into from
Jun 18, 2023

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Jun 16, 2023 •
edited
Loading

What does this PR do?

  1. Raises ValueError if user has mixed initialization without syncing module states
  2. Patches error when loading monolith ckpt with optimizer differing from ckpt
  3. Patches error where user specifies load rank 0 only but then doesn't actually pass a load path

dakinggg
dakinggg reviewed Jun 16, 2023
View reviewed changes
composer/core/state.py Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Jun 16, 2023
View reviewed changes
composer/core/state.py Outdated Show resolved Hide resolved
dakinggg
dakinggg approved these changes Jun 18, 2023
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mvpatel2000 mvpatel2000 merged commit ccb4729 into mosaicml:dev Jun 18, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/debug-mono branch June 18, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@bcui19 bcui19 Awaiting requested review from bcui19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @dakinggg