Lazy loading of non-core dependencies #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Conditioning imports of optional modules at the source 2. In tests, explicitely surpressing ModuleNotFoundErrors for optional imports
ravi-mosaicml
changed the title
hanlint
requested changes
Nov 11, 2021
coryMosaicML
pushed a commit
to coryMosaicML/composer
that referenced
this pull request
Feb 23, 2022
Resolved lazy-loading of non-core dependencies by using guarded imports. Non-core dependencies should be imported either a) in a function, and/or b) if guarded with TYPE_CHECKING (we run pyright when installing everything). Updated the tests to selectively ignore some ModuleNotFound errors and instead trigger a pytest.skip. Tested manually by running tests on an installation of pip install composer[dev]. In the future, Jenkins will run this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved lazy-loading of non-core dependencies by using guarded imports.
Non-core dependencies should be imported either a) in a function, and/or b) if guarded with
TYPE_CHECKING(we run pyright when installing everything).Updated the tests to selectively ignore some
ModuleNotFounderrors and instead trigger a pytest.skip.Tested manually by running tests on an installation of
pip install composer[dev]. In the future, Jenkins will run this test.