Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework to modern Materialized Views #62

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

mzealey
Copy link
Contributor

@mzealey mzealey commented Apr 21, 2023

  • Move away from using inner MV's to separate MV and defined tables as per CH recommendations
  • Switch all SummingMergeTree to AggregatingMergeTree to allow for more functionality in future if needed

- Move away from using inner MV's to separate MV and defined tables as
  per CH recommendations
- Switch all SummingMergeTree to AggregatingMergeTree to allow for more
  functionality in future if needed
@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for unrivaled-llama-9deaa9 canceled.

Name Link
🔨 Latest commit 5b41c6b
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-llama-9deaa9/deploys/6442925e3988f900083d10b4

@mosajjal
Copy link
Owner

looks good. I just tested it against some local data and it works. do you have any testing/benchmark on this? wondering if this is gonna affect the performance.

@mzealey
Copy link
Contributor Author

mzealey commented Apr 22, 2023 via email

@mosajjal mosajjal merged commit be3a62f into mosajjal:main Apr 22, 2023
@dnsstub
Copy link

dnsstub commented Apr 24, 2023

hi @mzealey

Move away from using inner MV's to separate MV and defined tables as per CH recommendations
it seems very much fine

`Switch all SummingMergeTree to AggregatingMergeTree to allow for more functionality in future if needed
can you please put some light over it because you are replacing every SummingMergeTree Instance with AggregatingMergeTree that doesnt seems to be efficient in every condition

`

@mzealey
Copy link
Contributor Author

mzealey commented Apr 24, 2023

I've never seen a performance difference between Summing and Aggregating (with SimpleAggregationFunction), and Aggregating gives you so much more flexibility over extending function if you need.

@dnsstub
Copy link

dnsstub commented Apr 24, 2023

i will post my comparisions here in 1 -2 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants