feat!: clusters improvements #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Aug 11, 2023
| ).then((keys) => { | ||
| // keys: [['key1', 'key2'], ['key3', 'key4']] | ||
| // flatten the array | ||
| cb(null, keys.reduce((acc, val) => acc.concat(val), [])) |
There was a problem hiding this comment.
wrap this in a nexttick or the callback might be called twice in case of errors
There was a problem hiding this comment.
could you explain me why this could be called twice? In case one of the promises fails the catch should be thrown, also why should nextick fix that problem?
robertsLando
changed the title
|
Did some preliminary testing on this and seems to work 👍 |
|
Thanks for the feedback @alumowa let me know when it's good to merge 👍🏻 |
|
@robertsLando feel free to merge it. tks!!! |
|
Done 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85
BREAKING CHANGE: For users using this module with CLUTERS the db schema has changed for
retainedmessages. There is a migration available inmigrations.jsnamedfrom9to10that can be used to move all db to the new format. Also, if you are passing aconnto options (that is using clusters) now you also have to setcluster : truein options. To make this change back compatibile and faster in non cluster envs that option is used in order to use a different set of operations that only works in cluster envs