Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace istanbul with nyc #253

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Jul 11, 2019

istanbul is not maintained anymore

istanbul is not maintained anymore
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit c0d5bd5 into moscajs:master Jul 11, 2019
mcollina pushed a commit that referenced this pull request Jul 11, 2019
* Non-Zero MessageId when QoS > 0

Aligned the MQTT 3.1.1 spec, http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718025

* Prolong waiting time (#252)

Travis CI sometimes is too slow, and is causing aedes broker not respond and fails the 'disconnect if a connect does not arrive in time' test

* Replace istanbul with nyc (#253)

* Replace istanbul with nyc

istanbul is not maintained anymore

* Update .gitignore

* Non-Zero MessageId when QoS > 0

Aligned the MQTT 3.1.1 spec, http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718025
@gnought gnought deleted the feature/use_nyc_for_coverage branch July 11, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants