Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete tests #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Feb 7, 2020

Those tests have been moved into aedes-protocol-decoder repo

@robertsLando
Copy link
Member

In case of' websocket-stream updated to ws' those were useful to check there was breaking changes on protocol-decoder. Like the _socket property that wasn't present

@gnought
Copy link
Collaborator Author

gnought commented Feb 7, 2020

Please test it in aedes-protocol-decoder.

@robertsLando
Copy link
Member

robertsLando commented Feb 7, 2020 via email

@robertsLando
Copy link
Member

@gnought I suggest to create a dummy protocol decoder test that simply parse data

https://github.com/moscajs/aedes/blob/master/lib/client.js#L80

@coveralls
Copy link

coveralls commented Jul 16, 2024

Pull Request Test Coverage Report for Build e15ec1ea18585b92aa748d276cd09be64bd7125a-PR-416

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 95.591%

Files with Coverage Reduction New Missed Lines %
lib/client.js 4 93.79%
Totals Coverage Status
Change from base Build 03de4157c47a301c2da1c8b5ecce1da4132d1919: -0.8%
Covered Lines: 734
Relevant Lines: 756

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants