Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin openmm to 7.5 #455

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Pin openmm to 7.5 #455

merged 2 commits into from
Aug 30, 2021

Conversation

jennyfothergill
Copy link
Contributor

PR Summary:

New openmm release causing issue in reproducibility study, so let's pin the version until we can determine what the error is.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #455 (40189e8) into master (b55b416) will not change coverage.
The diff coverage is n/a.

❗ Current head 40189e8 differs from pull request most recent head b2c02f7. Consider uploading reports for the commit b2c02f7 to get more accurate results

@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   73.87%   73.87%           
=======================================
  Files          17       17           
  Lines        1849     1849           
=======================================
  Hits         1366     1366           
  Misses        483      483           

@justinGilmer
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@daico007 daico007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge when tests pass.

Copy link
Contributor

@justinGilmer justinGilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests pass, LGTM!

@daico007 daico007 merged commit 34da37c into mosdef-hub:master Aug 30, 2021
@jennyfothergill jennyfothergill deleted the pin/openmm branch December 7, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants