Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous updates #465

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Miscellaneous updates #465

merged 4 commits into from
Oct 1, 2021

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Sep 28, 2021 •
edited
Loading

PR Summary:

  • unset execute permission
  • remove accidentally tracked file
  • fix PEP8 E722 and F523

PR Checklist

  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

justinGilmer
justinGilmer approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@justinGilmer justinGilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @e-kwsm !

@justinGilmer justinGilmer merged commit 5679d70 into mosdef-hub:master Oct 1, 2021
@e-kwsm e-kwsm deleted the misc branch October 2, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinGilmer justinGilmer justinGilmer approved these changes

@umesh-timalsina umesh-timalsina umesh-timalsina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-kwsm @umesh-timalsina @justinGilmer