Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic gro file reader #26

Merged
merged 6 commits into from
Feb 17, 2019
Merged

Add basic gro file reader #26

merged 6 commits into from
Feb 17, 2019

Conversation

mattwthompson
Copy link
Member

http://manual.gromacs.org/current/reference-manual/file-formats.html#gro

  • Read name of system
  • Read name and position of each atom
  • Read box information (with caveats forced by GROMACS itself)

Note that residue information and atom numbers are not stored anywhere (though I added dummy variables to read them in)

@mattwthompson mattwthompson added the enhancement New feature or request label Feb 10, 2019
topology/formats/gro.py Outdated Show resolved Hide resolved
topology/formats/gro.py Outdated Show resolved Hide resolved
@mattwthompson
Copy link
Member Author

I updated this just a little bit - in 622f19d I decided it's better to explicitly state the units, even though they'd be converted from float to u.nm without much trouble, if only to avoid a UserWarning. But it's probably best to do that anyway.

I would like #35 merged in before this; I think it would make checking the box simpler and make other comparisons that we may wish to do easier.

topology/formats/gro.py Show resolved Hide resolved
topology/tests/test_gro.py Show resolved Hide resolved
@mattwthompson mattwthompson merged commit 5943d7b into master Feb 17, 2019
@mattwthompson mattwthompson deleted the read-gro branch February 28, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants