Make MCF writer feature complete #560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add fixed angle support * Fix charge sign error (gmso-wide) * Update ring identification to handle fused systems (mbuild mosdef-hub#744) * Increase floating point accuracy * Increase element type length and atom type length * Correctly write atom indices for bonds/angles/dihedrals/impropers
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 90.49% 91.26% +0.76%
==========================================
Files 55 53 -2
Lines 4410 4077 -333
==========================================
- Hits 3991 3721 -270
+ Misses 419 356 -63
Continue to review full report at Codecov.
|
Merged
|
Replaced by #756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GMSO has come far since my initial MCF writer PR. The goal of this PR is to make the MCF writer feature complete (i.e., support all the potential types we support with Cassandra).
Most of the features are implemented at this point, but I need to add unit tests.