Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose options for mol2 and element #729

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

daico007
Copy link
Member

Add verbose options to reduce the amount of warnings raised when parsing mol2 file and element.

@@ -132,7 +134,7 @@
match=r"No element detected for site .+ with index \d+, "
r"consider manually adding the element to the topology$",
):
top = Topology.load(get_fn("neopentane.mol2"))
top = Topology.load(get_fn("neopentane.mol2"), verbose=True)

Check notice

Code scanning / CodeQL

Unused local variable

Variable top is not used.
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: -0.09 ⚠️

Comparison is base (f5aa91b) 92.13% compared to head (684dcef) 92.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   92.13%   92.04%   -0.09%     
==========================================
  Files          67       67              
  Lines        6456     6459       +3     
==========================================
- Hits         5948     5945       -3     
- Misses        508      514       +6     
Impacted Files Coverage Δ
gmso/core/element.py 89.74% <87.50%> (-5.09%) ⬇️
gmso/formats/mol2.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like this addition, thanks!

@daico007 daico007 merged commit 8cb3e59 into mosdef-hub:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants