-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smiles string conversion using pybel backend #1056
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
==========================================
- Coverage 90.53% 88.66% -1.88%
==========================================
Files 60 60
Lines 8421 8423 +2
==========================================
- Hits 7624 7468 -156
- Misses 797 955 +158 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix bleeding test, otherwise this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after fixing bleeding test
So the issue with the bleeding test has to do with the python version specified. When updating the env with specs from foyer/gmso env.yml, the python version got updated to python 3.10. The fixes would need to be applied on gmso/foyer sides, by adding an upper constraint for python version |
Add smiles string conversion using pybel backend (mosdef-hub#1056)
PR Summary:
A quick path to go from mbuild compound to smiles string through openbabel. I am using openbabel to guess the bond orders of the resulted molecule and output a smile string. This can be a temp solution before we can have our own smiles string writer. Pending unit tests.
PR Checklist