Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lammps impropers docstring #1120

Merged
merged 2 commits into from
May 31, 2023

Conversation

daico007
Copy link
Member

PR Summary:

Fix the docstring for LAMMPS improper writers.

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@daico007 daico007 marked this pull request as ready for review May 29, 2023 17:22
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (12efb1b) 87.13% compared to head (b93c3d3) 87.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1120   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          62       62           
  Lines        6420     6420           
=======================================
  Hits         5594     5594           
  Misses        826      826           
Impacted Files Coverage Δ
mbuild/formats/lammpsdata.py 92.96% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@chrisiacovella chrisiacovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes what we discussed in the dev meeting a little while ago, so looks good.

@daico007 daico007 merged commit d83e341 into mosdef-hub:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants