Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisableMemDump 这个方法是不是笔误了 #105

Closed
857420437 opened this issue Jun 30, 2022 · 1 comment
Closed

DisableMemDump 这个方法是不是笔误了 #105

857420437 opened this issue Jun 30, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@857420437
Copy link

// DisableMemDump disables the mem dump.
func (h *BHolmes) DisableMemDump() *BHolmes {
h.opts.gCHeapOpts.Enable = false
return h
}
是不是应该是
// DisableMemDump disables the mem dump.
func (h *BHolmes) DisableMemDump() *BHolmes {
h.opts.memOpts.Enable = false
return h
}

@taoyuanyuan
Copy link
Contributor

老哥好眼力, 欢迎PR 👏🏻

@taoyuanyuan taoyuanyuan added the bug Something isn't working label Jun 30, 2022
AtlanCI added a commit to AtlanCI/holmes that referenced this issue Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants