Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip goroutine dump when already finished a thread check dump in a single loop. #103

Merged
merged 2 commits into from
Jul 1, 2022
Merged

feat: skip goroutine dump when already finished a thread check dump in a single loop. #103

merged 2 commits into from
Jul 1, 2022

Conversation

AtlanCI
Copy link
Contributor

@AtlanCI AtlanCI commented Jun 24, 2022 •
edited
Loading

@mosn-community-bot mosn-community-bot bot added cla:yes question Further information is requested size/S labels Jun 24, 2022
@AtlanCI AtlanCI changed the title feat: skip goroutine dump when already finished a thread check dump i… feat: skip goroutine dump when already finished a thread check dump in a single loop. Jun 24, 2022
doujiang24
doujiang24 requested changes Jun 25, 2022
View reviewed changes
Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to change the order here:

holmes/holmes.go

Line 333 in 721dac3

h.goroutineCheckAndDump(gNum)

@AtlanCI
Copy link
Contributor Author

AtlanCI commented Jun 25, 2022

Also need to change the order here:

holmes/holmes.go

Line 333 in 721dac3

h.goroutineCheckAndDump(gNum)

I have adjusted

@AtlanCI AtlanCI requested a review from doujiang24 June 25, 2022 07:12
@doujiang24 doujiang24 merged commit aca53eb into mosn:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiang24 doujiang24 doujiang24 approved these changes

Assignees
No one assigned
Labels
cla:yes question Further information is requested size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtlanCI @doujiang24