Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:supports dump goroutine to logger and fix typos #91

Merged
merged 11 commits into from
Mar 31, 2022
Merged

feat:supports dump goroutine to logger and fix typos #91

merged 11 commits into from
Mar 31, 2022

Conversation

Jun10ng
Copy link
Contributor

@Jun10ng Jun10ng commented Mar 29, 2022

@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/S labels Mar 29, 2022
@Jun10ng Jun10ng requested a review from doujiang24 March 29, 2022 14:24
This was referenced Mar 29, 2022
Closed
Closed
doujiang24
doujiang24 reviewed Mar 30, 2022
View reviewed changes
holmes.go Outdated Show resolved Hide resolved
@Jun10ng Jun10ng requested a review from doujiang24 March 30, 2022 08:36
doujiang24
doujiang24 reviewed Mar 30, 2022
View reviewed changes
Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to write the CPU profile to logger too?
otherwise, LGTM.

@Jun10ng
Copy link
Contributor Author

Jun10ng commented Mar 30, 2022

need to write the CPU profile to logger too? otherwise, LGTM.

yeah, cpu doesn't use this function.
I will add it.

@Jun10ng Jun10ng requested a review from doujiang24 March 30, 2022 11:20
doujiang24
doujiang24 reviewed Mar 31, 2022
View reviewed changes
holmes.go Outdated Show resolved Hide resolved
holmes.go Outdated Show resolved Hide resolved
@doujiang24 doujiang24 merged commit ca4d9d3 into mosn:master Mar 31, 2022
@doujiang24
Copy link
Member

oh, also need doc for the new WithDumpToLogger API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiang24 doujiang24 doujiang24 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jun10ng @doujiang24