Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test all the quickstart documents #456

Merged
merged 61 commits into from
May 9, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Apr 9, 2022

What this PR does:

  • Test all the quickstart documents.
  • Fix all the test failure
  • Make the test script less intrusive so that we don't have to modify the documents to meet the standard

I wrote a tool mdx to make it easier to write runnable markdown files.

Ignore list:

  • We will not test apollo quickstart demo because the github workflow cannot connect to the apollo server :(
    I don't know why. Maybe it's caused by that wall
    image

Todo:
- [x] modify the pr title checker so that it won't warn every time

Which issue(s) this PR fixes:

Fixes #447

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #456 (c542988) into main (94a6b97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         120      120           
  Lines        6382     6382           
=======================================
  Hits         3874     3874           
  Misses       2139     2139           
  Partials      369      369           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7300c2...c542988. Read the comment docs.

@seeflood seeflood changed the title [WIP]ci: test all the quickstarts [WIP]ci: test all the quickstart documents Apr 9, 2022
seeflood added 10 commits May 8, 2022 18:37
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
@seeflood seeflood changed the title [WIP]ci: test all the quickstart documents ci: test all the quickstart documents May 8, 2022
@seeflood
Copy link
Member Author

seeflood commented May 8, 2022

@Xunzhuo Please help review this PR. Layotto CI will test all the quickstart documentation.
I hate shell scripts. It wasted me too much time fixing the weird errors 😢
If I had another chance , I will write this tool in golang, java ,nodejs , python or any other programming language instead of shell !
image

@seeflood seeflood requested review from a team May 8, 2022 14:23
Signed-off-by: seeflood <349895584@qq.com>
Signed-off-by: seeflood <349895584@qq.com>
Xunzhuo and others added 3 commits May 8, 2022 23:52
Signed-off-by: Xunzhuo <mixdeers@gmail.com>
chore: merge quickstart checks into one
Signed-off-by: seeflood <349895584@qq.com>
@seeflood seeflood requested a review from Xunzhuo May 9, 2022 03:26
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @seeflood, we should not let core team spend more time on these infrastructure tasks anymore, let us move on:) Core abilities for new CI in Layotto have already been strong enough for now at least, we could label a good first issue on other related tasks.

@seeflood
Copy link
Member Author

seeflood commented May 9, 2022

LGTM, thanks @seeflood, we should not let core team spend more time on these infrastructure tasks anymore, let us move on:) Core abilities for new CI in Layotto have already been strong enough for now at least, we could label a good first issue on other related tasks.

Agreed!

@Xunzhuo Xunzhuo merged commit 68f933c into mosn:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: 使用工具自动测试 Quickstart 文档
3 participants