-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Dapr pubsub API #465
Conversation
Codecov Report
@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 60.58% 60.06% -0.52%
==========================================
Files 127 128 +1
Lines 6652 6769 +117
==========================================
+ Hits 4030 4066 +36
- Misses 2235 2311 +76
- Partials 387 392 +5
Continue to review full report at Codecov.
|
After v0.4 released , we can start reviewing and merging this PR |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
@LXPWing Hi, please resolve the conflicts so that we can continue with this PR |
# Conflicts: # pkg/grpc/default_api/api_pubsub.go
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does:
Re-pull request because of git conflict add Dapr pubsub API #361