Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatically upload binary files when releasing new version #566

Merged
merged 1 commit into from
May 14, 2022

Conversation

SignorMercurio
Copy link
Contributor

What this PR does:

Add a few steps in Layotto Release Pipeline so that binaries are auto uploaded to Release page when a new version is released.

Which issue(s) this PR fixes:

Fixes #563

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@mosn-community-bot
Copy link

Hi @SignorMercurio, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #566 (4260c48) into main (8d7d7c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         120      120           
  Lines        6382     6382           
=======================================
  Hits         3874     3874           
  Misses       2139     2139           
  Partials      369      369           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c3e69...4260c48. Read the comment docs.

@seeflood seeflood requested a review from Xunzhuo May 14, 2022 04:02
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @SignorMercurio

@Xunzhuo
Copy link
Member

Xunzhuo commented May 14, 2022

Test here: https://github.com/Xunzhuo/layotto/releases/tag/v0.5.0, the artifacts uploaded automatically when creating a tag, the release manager does not need to manually download and upload files anymore.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coool
@SignorMercurio Thanks for your contribution !

@seeflood seeflood merged commit 1947177 into mosn:main May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: automatically upload binary files when releasing new version
3 participants