-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic secret #574
feat: dynamic secret #574
Conversation
Great! |
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 60.91% 60.89% -0.02%
==========================================
Files 120 122 +2
Lines 6389 6432 +43
==========================================
+ Hits 3892 3917 +25
- Misses 2124 2133 +9
- Partials 373 382 +9
Continue to review full report at Codecov.
|
# Conflicts: # components/sequencer/types.go
@seeflood I remember wrong , i only add dynamic secret&config of sequencer , you can review first , If ok, I will continue to modify other components |
@ZLBer ok |
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. This feature is really useful. Thanks!
I can hep modify the sidebar of the doc site, after this PR is merged |
can you give some notes for reviewer?eg. attach an issue to declare what the pr does |
Good point. The issue is #472 |
I'm going to merge this PR and use this feature to write a test for #556 |
What this PR does:
User can reference secrets in their config.json. Layotto will help inject the refered secrets into the component metadata
Which issue(s) this PR fixes:
Fixes #472
Special notes for your reviewer:
Does this PR introduce a user-facing change?: