-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: webassembly code analysis #575
Conversation
I wonder which tool you used to draw these diagrams. These diagrams look very professional, much better than mine 😢 |
LOL, really? The previous one is quoted from the previous Mosn source code analysis, which should be drawn with PPT. The following picture is drawn casually with the online software Processon. The function of this software is similar to that of visio, but it can be drawn anywhere and opened. This is very convenient and you can try it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rayowang Hi , I uploaded the images to CDN and submitted a PR to your branch
Please review rayowang#1
It's weird that this PR didn't update automatically after merging rayowang#1 😢 |
I was wondering about this problem just now, and later found out that I have two similar branch names, so the branch of this pr is wasm_code_analysis, not webassembly_code_analysis. So now, do I cherry-pick the changes or do you pr to the wasm_code_analysis branch? |
@rayowang OK you can cherry pick those changes |
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
… wasm_code_analysis
ok, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks!
What this PR does:
webassembly code analysis
Which issue(s) this PR fixes:
#427