-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Optimized pubsub api demo #594
Conversation
Hi @gdutChenxj, welcome to mosn community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
Codecov Report
@@ Coverage Diff @@
## main #594 +/- ##
=======================================
Coverage 60.92% 60.92%
=======================================
Files 120 120
Lines 6377 6377
=======================================
Hits 3885 3885
Misses 2120 2120
Partials 372 372 Continue to review full report at Codecov.
|
|
Fixed. I closed and reopened this PR to rerun the workflow .
Yes you are right :) So, could u help modify the documentation in this PR? |
i will update the doc for the new demo |
@seeflood I have updated the quick start doc and it can work well in my local test. But there is a confliction need somebody with write access to handle. |
Thanks ! I just saw this message.
|
Co-authored-by: seeflood <zhou.qunli@foxmail.com>
Co-authored-by: seeflood <zhou.qunli@foxmail.com>
Co-authored-by: seeflood <zhou.qunli@foxmail.com>
Co-authored-by: seeflood <zhou.qunli@foxmail.com>
@seeflood all conversations are resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for your contribution and welcome to the community !
What this PR does:
mix pubsub demo
Which issue(s) this PR fixes:
Fixes #584