Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check unused package in go.mod #595

Merged
merged 15 commits into from
May 24, 2022
Merged

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented May 23, 2022

Signed-off-by: seeflood zhou.qunli@foxmail.com

What this PR does:

  • Check unused package in submodules' go.mod .
    image

  • Fix some linter issues in submodules

Which issue(s) this PR fixes:

Fixes #597

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #595 (fd44251) into main (5bada7f) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head fd44251 differs from pull request most recent head ec14ff2. Consider uploading reports for the commit ec14ff2 to get more accurate results

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         120      120           
  Lines        6382     6375    -7     
=======================================
- Hits         3874     3870    -4     
+ Misses       2139     2136    -3     
  Partials      369      369           
Impacted Files Coverage Δ
components/file/hdfs/hdfs.go 46.15% <66.66%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bada7f...ec14ff2. Read the comment docs.

Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood seeflood changed the title [WIP]ci: improve linter ci: check unused package in go.mod May 23, 2022
@seeflood seeflood requested review from Xunzhuo and a team May 23, 2022 13:16
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood seeflood requested a review from Xunzhuo May 24, 2022 06:52
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit 2e96a1e into mosn:main May 24, 2022
@seeflood seeflood deleted the improve_linter branch May 24, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: check unused dependency in go.mod
3 participants