Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configuration API returns wrong app_id #629

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

MichaelDeSteven
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #613

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot
Copy link

Hi @MichaelDeSteven, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #629 (7ed12eb) into main (36ed813) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 7ed12eb differs from pull request most recent head 5797639. Consider uploading reports for the commit 5797639 to get more accurate results

@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372           
Impacted Files Coverage Δ
pkg/grpc/default_api/api_configuration.go 78.40% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5a3e4...5797639. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood
Copy link
Member

seeflood commented Jun 7, 2022

@MichaelDeSteven Thanks for your contribution!
It fixes the wrong app_id. However, there's another bug in #613 that the store_name is wrong, too 😭
Anyway, we can leave the store_name bug as a TODO thing and fix it in a new PR.
Welcome to the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: configuration API returns wrong app_id and store_name
3 participants