Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use docker-compose to run quickstart #632

Merged
merged 10 commits into from
Jun 8, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Jun 7, 2022

What this PR does:

  • Use docker-compose to run quickstart
    You can check the new doc site at https://seeflood.github.io/layotto/#/zh/start/state/start
    image

  • Remove init function in tracer
    image

  • improve docs

    • docs/zh/development/contributing-doc.md
    • docs/en/development/contributing-doc.md
    • zh/start/pubsub/start
    • en/start/pubsub/start
    • zh/operation/

Which issue(s) this PR fixes:

Fixes #620

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood seeflood requested review from Xunzhuo, LXPWing and a team and removed request for Xunzhuo June 7, 2022 15:14
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #632 (1de96ec) into main (c9081af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #632   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9081af...1de96ec. Read the comment docs.

Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood seeflood changed the title chore: Use docker-compose to run quickstart [WIP]chore: Use docker-compose to run quickstart Jun 8, 2022
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood seeflood changed the title [WIP]chore: Use docker-compose to run quickstart chore: Use docker-compose to run quickstart Jun 8, 2022
@seeflood
Copy link
Member Author

seeflood commented Jun 8, 2022

@mosn/layotto-commiter @mosn/layotto-pmc I propose that we merge this PR ASAP, so that we can show windows users how to play with Layotto.
We can do PR review after merging it. If you find any issues, I can submit new PR to fix them

@seeflood seeflood merged commit 309ed3a into mosn:main Jun 8, 2022
@seeflood seeflood deleted the remove_init_in_tracer branch June 8, 2022 13:42
@seeflood seeflood linked an issue Jun 29, 2022 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let users run our demo without go environment 无法正常在windows环境进行build
5 participants