Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zipkin #642

Merged
merged 40 commits into from
Jun 22, 2022
Merged

feat: add zipkin #642

merged 40 commits into from
Jun 22, 2022

Conversation

LXPWing
Copy link
Member

@LXPWing LXPWing commented Jun 12, 2022

What this PR does:
layotto add zipkin feature

Which issue(s) this PR fixes:
fix #593

@seeflood
Copy link
Member

seeflood commented Jun 18, 2022

6/18 community meeting:
No need to support kafka reporter. We can focus on the http reporter in this PR

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #642 (18502fe) into main (66e64e9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files         120      120           
  Lines        6384     6384           
=======================================
  Hits         3890     3890           
  Misses       2121     2121           
  Partials      373      373           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e64e9...18502fe. Read the comment docs.

@seeflood
Copy link
Member

seeflood commented Jun 21, 2022

Thanks!

Review process:

  • doc rendered successfully
    image

  • run quickstart successfully

  • review code details

  • add section "run layotto using docker" in the doc

  • upload image to CDN

docs/zh/start/trace/zipkin.md Outdated Show resolved Hide resolved
diagnostics/zipkin/grpc_tracer.go Outdated Show resolved Hide resolved
diagnostics/zipkin/grpc_tracer.go Outdated Show resolved Hide resolved
diagnostics/zipkin/grpc_tracer.go Outdated Show resolved Hide resolved
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I uploaded the image to CDN

@seeflood seeflood requested review from a team June 21, 2022 14:35
@seeflood seeflood merged commit 34da00a into mosn:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: layotto integration Zipkin
4 participants