chore: demo should panic when errors occur #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
mosn-community-bot
bot
added
cla:yes
question
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
=======================================
Coverage 60.92% 60.92%
=======================================
Files 120 120
Lines 6377 6377
=======================================
Hits 3885 3885
Misses 2120 2120
Partials 372 372 Continue to review full report at Codecov.
|
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
wenxuwan
approved these changes
Jun 14, 2022
zhenjunMa
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #586
Fixes #649
Special notes for your reviewer:
Does this PR introduce a user-facing change?: