-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build proxyv2 image and push it to dockerhub #655
Conversation
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
=======================================
Coverage 60.92% 60.92%
=======================================
Files 120 120
Lines 6377 6377
=======================================
Hits 3885 3885
Misses 2120 2120
Partials 372 372 Continue to review full report at Codecov.
|
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, need to confirm that if we should add this to release pipeline?
@Xunzhuo Yes we do. Since I haven't deployed the image with istio, I'm not sure if I have to modify it again. |
Signed-off-by: seeflood zhou.qunli@foxmail.com
What this PR does:
reference:
https://mosn.io/docs/user-guide/start/istio/
todo:
layotto/proxyv2:latest
image with make scriptWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: