Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace current apollo sdk with the official one #663

Merged
merged 33 commits into from
Jun 22, 2022

Conversation

MichaelDeSteven
Copy link
Contributor

@MichaelDeSteven MichaelDeSteven commented Jun 21, 2022

What this PR does:

Which issue(s) this PR fixes:

Fixes #661

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@seeflood
Copy link
Member

The CI fails because a new package requires go 1.17
image

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #663 (f738737) into main (c76afc1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files         120      120           
  Lines        6384     6384           
=======================================
  Hits         3890     3890           
  Misses       2121     2121           
  Partials      373      373           
Impacted Files Coverage Δ
components/configstores/apollo/change_listener.go 82.60% <ø> (ø)
components/configstores/apollo/repository.go 12.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76afc1...f738737. Read the comment docs.

@MichaelDeSteven
Copy link
Contributor Author

The CI fails because a new package requires go 1.17 image

Done

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@seeflood seeflood merged commit 0ecca3a into mosn:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace current apollo sdk with the official one; 将 apollo sdk 替换成官方 sdk
5 participants