Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify istio version& add layotto_without_xds #714

Merged
merged 11 commits into from
Jul 12, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Jul 11, 2022

Signed-off-by: seeflood zhou.qunli@foxmail.com

What this PR does:

  • modify istio version in main.go
    image
    I used to modify istio version with Makefile, but I reverted it because I want the makefile script decoupled with the code.
    For example, if the code doesn't import xDS related packages, makefile will get error when trying to modify the istio version.

  • add layotto_without_xds for non-xDS users
    image

Which issue(s) this PR fixes:

Fixes #

It's subtask of #471

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #714 (de6fc6c) into main (f87a806) will not change coverage.
The diff coverage is n/a.

❗ Current head de6fc6c differs from pull request most recent head c2a0e21. Consider uploading reports for the commit c2a0e21 to get more accurate results

@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   60.89%   60.89%           
=======================================
  Files         122      122           
  Lines        6432     6432           
=======================================
  Hits         3917     3917           
  Misses       2133     2133           
  Partials      382      382           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87a806...c2a0e21. Read the comment docs.

@seeflood seeflood requested review from a team July 11, 2022 09:10
@seeflood seeflood merged commit e975d73 into mosn:main Jul 12, 2022
@seeflood seeflood deleted the istio_integrate branch July 12, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants