feat: InvokeService support specific target address #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 60.56% // Head: 60.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 60.56% 60.61% +0.04%
==========================================
Files 133 133
Lines 8323 8327 +4
==========================================
+ Hits 5041 5047 +6
+ Misses 2705 2704 -1
+ Partials 577 576 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…into specify_target_address
|
Thanks! |
zhenjunMa
approved these changes
Aug 2, 2022
seeflood
requested changes
Aug 2, 2022
MoonShining
reviewed
Aug 3, 2022
2 tasks
seeflood
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
lgtm. We can improve this feature in the future.
For now, @kevinten10 needs this feature to do POC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
user can specific provider ip address with set "rpc_target_address" in grpc header, layotto will send the request to specific ip address.
Which issue(s) this PR fixes:
Fixes #705
Special notes for your reviewer:
Does this PR introduce a user-facing change?: