Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify code structure to make it easier to generate code. #774

Merged
merged 15 commits into from
Sep 7, 2022

Conversation

seeflood
Copy link
Member

Signed-off-by: seeflood zhou.qunli@foxmail.com

What this PR does:
modify code structure to make it easier to generate code.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
# Conflicts:
#	cmd/layotto/main.go
#	pkg/grpc/grpc_api.go
#	pkg/runtime/runtime.go
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 60.61% // Head: 60.65% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (fc0ae8e) compared to base (79772ee).
Patch coverage: 81.94% of modified lines in pull request are covered.

❗ Current head fc0ae8e differs from pull request most recent head fc63257. Consider uploading reports for the commit fc63257 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   60.61%   60.65%   +0.04%     
==========================================
  Files         133      137       +4     
  Lines        8327     8370      +43     
==========================================
+ Hits         5047     5077      +30     
- Misses       2704     2716      +12     
- Partials      576      577       +1     
Impacted Files Coverage Δ
pkg/runtime/config.go 60.00% <ø> (ø)
pkg/runtime/options.go 43.33% <ø> (ø)
pkg/runtime/options_generated.go 0.00% <0.00%> (ø)
sdk/go-sdk/client/client.go 92.30% <ø> (-1.03%) ⬇️
pkg/runtime/runtime.go 59.10% <73.52%> (-1.23%) ⬇️
components/hello/helloworld/helloworld.go 100.00% <100.00%> (ø)
pkg/runtime/component_generated.go 100.00% <100.00%> (ø)
pkg/runtime/context_generated.go 100.00% <100.00%> (ø)
sdk/go-sdk/client/client_generated.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood
Copy link
Member Author

seeflood commented Sep 1, 2022

please ignore the linter issue:
image
I will submit a new PR to generate code for it

@seeflood seeflood linked an issue Sep 7, 2022 that may be closed by this pull request
29 tasks
@seeflood seeflood merged commit 9d12f9a into mosn:main Sep 7, 2022
@seeflood seeflood deleted the sdk_generator branch September 7, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: auto-generate the code and documentation based on the proto files
3 participants