Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): support email api & phone call api #780

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Sep 7, 2022

Signed-off-by: seeflood zhou.qunli@foxmail.com

What this PR does:
Support email api & phone call api.
All the stuff in this PR is generated by tools, see https://mosn.io/layotto/#/en/api_reference/how_to_generate_api_doc

Which issue(s) this PR fixes:

Fixes #717

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <zhou.qunli@foxmail.com>
zhenjunMa
zhenjunMa previously approved these changes Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Base: 60.61% // Head: 60.56% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (ddabc14) compared to base (79772ee).
Patch coverage: 74.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   60.61%   60.56%   -0.05%     
==========================================
  Files         133      133              
  Lines        8327     8340      +13     
==========================================
+ Hits         5047     5051       +4     
- Misses       2704     2712       +8     
- Partials      576      577       +1     
Impacted Files Coverage Δ
pkg/runtime/config.go 60.00% <ø> (ø)
pkg/runtime/options.go 43.33% <ø> (ø)
sdk/go-sdk/client/client.go 92.30% <ø> (-1.03%) ⬇️
pkg/runtime/runtime.go 59.10% <66.66%> (-1.23%) ⬇️
components/hello/helloworld/helloworld.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Copy link
Member

@kevinten10 kevinten10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

components/email/struct_generated.go Show resolved Hide resolved
@seeflood seeflood merged commit 767f58f into mosn:main Sep 13, 2022
@seeflood seeflood deleted the email_phone branch September 13, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Email notify API [SaaS API]
4 participants