Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): generate new methods for existing APIs #784

Merged
merged 14 commits into from
Sep 27, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented Sep 13, 2022

Signed-off-by: seeflood zhou.qunli@foxmail.com

What this PR does:
generate new methods for existing APIs.

docs:
https://github.com/seeflood/protoc-gen-p6#masters-commands

https://seeflood.github.io/layotto/#/zh/start/api_plugin/generate

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
# Conflicts:
#	spec/proto/extension/v1/email/email.proto
#	spec/proto/extension/v1/phone/phone.proto
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 60.56% // Head: 60.56% // No change to project coverage 👍

Coverage data is based on head (6354c01) compared to base (8cfe116).
Patch has no changes to coverable lines.

❗ Current head 6354c01 differs from pull request most recent head b249fa5. Consider uploading reports for the commit b249fa5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         133      133           
  Lines        8340     8340           
=======================================
  Hits         5051     5051           
  Misses       2712     2712           
  Partials      577      577           
Impacted Files Coverage Δ
pkg/wasm/dispatch.go 23.80% <0.00%> (ø)
components/trace/span.go 72.41% <0.00%> (ø)
components/trace/utils.go 60.00% <0.00%> (ø)
sdk/go-sdk/client/lock.go 100.00% <0.00%> (ø)
components/trace/export.go 92.85% <0.00%> (ø)
sdk/go-sdk/client/state.go 75.49% <0.00%> (ø)
pkg/runtime/lock/factory.go 100.00% <0.00%> (ø)
sdk/go-sdk/client/client.go 92.30% <0.00%> (ø)
sdk/go-sdk/client/invoke.go 78.66% <0.00%> (ø)
sdk/go-sdk/client/pubsub.go 60.00% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seeflood seeflood merged commit 11fb2cd into mosn:main Sep 27, 2022
@seeflood seeflood deleted the compilation_directive branch September 27, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants