Prevent deadlock in RobustChannel.reopen() #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darsstar
changed the title
Darsstar
force-pushed
the
prevent-deadlock-in-channel-reopen
branch
2 times, most recently
from
20071c2
to
5b04c04
Compare
Darsstar
force-pushed
the
prevent-deadlock-in-channel-reopen
branch
from
5b04c04
to
5b2f6c8
Compare
mosquito
approved these changes
Mar 19, 2024
decaz
approved these changes
Mar 19, 2024
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt this deserves it's own PR instead of including it in #615.
It is late, so here is the best, but consice, description I can currently manage:
Connection.ready()is how users should check if the connection is ready, internallyConnection.transport.ready()should be used ifRobustConnection.__reconnect_task()might cause it to be executed.