Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArrayTuple element construction #117

Merged
merged 2 commits into from Apr 30, 2021

Conversation

xqms
Copy link
Contributor

@xqms xqms commented Apr 30, 2021

Fix for #116. It also includes a unit test which exposes the problem.

Curiously, I couldn't get ASan to detect the usage of uninitialized memory. Valgrind reports it, however.

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #117 (ffe9691) into master (1114af5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         105      105           
  Lines        7611     7611           
=======================================
  Hits         7425     7425           
  Misses        186      186           
Impacted Files Coverage Δ
src/Corrade/Containers/ArrayTuple.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1114af5...ffe9691. Read the comment docs.

@mosra mosra added this to the 2020.0b milestone Apr 30, 2021
@mosra mosra added this to TODO in Containers via automation Apr 30, 2021
Copy link
Owner

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test is great, thanks.

ArrayView<Big> bigs;
ArrayTuple data{
{17, chars},
{7, bigs}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bigs, haha :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, we have to be consistent :D

@mosra mosra merged commit ffe9691 into mosra:master Apr 30, 2021
Containers automation moved this from TODO to Done Apr 30, 2021
@xqms xqms deleted the bugfix/arraytuple_constructor branch April 30, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Containers
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants