Fix ArrayTuple element construction #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This catches the bug discussed in mosra#116.
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 105 105
Lines 7611 7611
=======================================
Hits 7425 7425
Misses 186 186
Continue to review full report at Codecov.
|
mosra
approved these changes
Apr 30, 2021
| ArrayView<Big> bigs; | ||
| ArrayTuple data{ | ||
| {17, chars}, | ||
| {7, bigs} |
There was a problem hiding this comment.
well, we have to be consistent :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #116. It also includes a unit test which exposes the problem.
Curiously, I couldn't get ASan to detect the usage of uninitialized memory. Valgrind reports it, however.