Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adb to android sdk relative path #10

Closed
wants to merge 6 commits into from

Conversation

hsdk123
Copy link
Contributor

@hsdk123 hsdk123 commented Dec 31, 2019

This just makes it more convenient in the event that adb isn't in one's path.

@mosra
Copy link
Owner

mosra commented Jan 1, 2020

Same as with #11, right now I can't reliably verify this doesn't break existing uses where adb might be in a different location, so I'll have to postpone this until I have a real computer again.

@mosra mosra mentioned this pull request Jan 1, 2020
87 tasks
@hsdk123
Copy link
Contributor Author

hsdk123 commented Jan 4, 2020

I should have switched branches when making this.. I'll close this for the moment and reopen later.

@hsdk123 hsdk123 closed this Jan 4, 2020
@mosra mosra added this to the 2020.0a milestone Jan 5, 2020
@mosra mosra reopened this Jun 10, 2020
@mosra
Copy link
Owner

mosra commented Jun 10, 2020

Finally merged the first commit (half-year delays, sorry).

Oh -- the rest is very cool. I'm interested in that also, so to avoid it getting lost/forgotten I'm reopening this PR. To make the change backwards-compatible I could imagine using cmake_parse_arguments() (which isn't in the minimal supported 3.4 yet, new in 3.5, but the Android toolchains requires 3.7 anyway, so that's okay) turning the function signature into for example (following the same format CMake is using in their docs):

android_create_apk(<target> <manifest> 
    [RESOURCES <res>] 
    [ASSETS <assets>])

If I get some time I can pick this up myself, just want to make sure this doesn't get forgotten :)

@mosra
Copy link
Owner

mosra commented Mar 22, 2024

The remaining TODO here -- passing paths to resources and assets -- is finally implemented in b3bd787 and deccc40, including proper dependency tracking for any files in given directories that either change, are added or are removed. Usage is as follows, I'll update the docs once I have confirmed that everything works as intended:

android_create_apk(<target> <manifest> 
    [RESOURCE_DIRECTORY <res>] 
    [ASSET_DIRECTORY <assets>])

@mosra mosra closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants