Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Enhance removing duplicated breakpoints #15

Closed
wants to merge 6 commits into from

Conversation

panzhongxian
Copy link

@panzhongxian panzhongxian commented Dec 17, 2021

Fix #14 and add more test cases about breakpoints.

@panzhongxian
Copy link
Author

@mostafa I merged debugger branch into dop251_master. Is this flow OK?

The following 4 commits fix #13 .

@panzhongxian
Copy link
Author

panzhongxian commented Dec 21, 2021

@mostafa Sorry if I messed things up. I've pushed a new commit to fix #11 in the single brnach. The latest commit seems ugly but it can work. Although I have removed the standard built-ins(mentioned here), the function still can't distinguish ordinary varibles and others(including functions, module names).

@mostafa
Copy link
Owner

mostafa commented Dec 23, 2021

@panzhongxian Thanks for the contribution! I'll test it.

@mostafa
Copy link
Owner

mostafa commented Dec 23, 2021

It works very well. Thanks! 👏

@mostafa
Copy link
Owner

mostafa commented Dec 23, 2021

I cherry-picked your commits into PR #18, so I'll close this PR and merge #18.

mostafa added a commit that referenced this pull request Dec 23, 2021
* Enhance removing duplicated breakpoints
* Update debugger test.
* Add get global and local variables functions

Co-authored-by: panzhongxian <panzhongxian0532@gmail.com>
@mostafa mostafa closed this Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants