This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
forked from dop251/goja
-
Notifications
You must be signed in to change notification settings - Fork 0
Enhance removing duplicated breakpoints #15
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panzhongxian
force-pushed
the
debugger
branch
from
December 17, 2021 03:35
820b02d
to
4dffcc8
Compare
@mostafa Sorry if I messed things up. I've pushed a new commit to fix #11 in the single brnach. The latest commit seems ugly but it can work. Although I have removed the standard built-ins(mentioned here), the function still can't distinguish ordinary varibles and others(including functions, module names). |
@panzhongxian Thanks for the contribution! I'll test it. |
It works very well. Thanks! 👏 |
mostafa
added a commit
that referenced
this pull request
Dec 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14 and add more test cases about breakpoints.