Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dotenv as a cli command (like cross-env) #181

Closed
wants to merge 11 commits into from

Conversation

c3riz88
Copy link

@c3riz88 c3riz88 commented Mar 5, 2017

I need this feature for web bundler usage (eg: broswerify + envify) for inject environment variables forwarded by .env file.

Thanks.

@coveralls
Copy link

coveralls commented Mar 5, 2017

Coverage Status

Coverage decreased (-6.4%) to 93.596% when pulling 604dd04 on mickaelvalmier:master into 825c1b2 on motdotla:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.4%) to 93.596% when pulling 604dd04 on mickaelvalmier:master into 825c1b2 on motdotla:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.3%) to 93.689% when pulling 1fa67cf on mickaelvalmier:master into 825c1b2 on motdotla:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.3%) to 93.689% when pulling 7df9513 on mickaelvalmier:master into 825c1b2 on motdotla:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-6.3%) to 93.689% when pulling 7df9513 on mickaelvalmier:master into 825c1b2 on motdotla:master.

@coveralls
Copy link

coveralls commented Mar 5, 2017

Coverage Status

Coverage decreased (-6.3%) to 93.75% when pulling c7da6a6 on mickaelvalmier:master into 825c1b2 on motdotla:master.

@maxbeatty
Copy link
Contributor

I think this would be better as its own module. I was going to suggest naming it "dotenv-cli" but looks like someone is already wrapping this module to make a CLI. Happy to link to one or both in the README

@coveralls
Copy link

coveralls commented Mar 6, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 4cb4bd8 on mickaelvalmier:master into 825c1b2 on motdotla:master.

@c3riz88
Copy link
Author

c3riz88 commented Mar 6, 2017

My bad, i've not checked if a similar module exists.

But in my point of vue, import a cli in the same module is a better way than a separates repositories.

I usually use dotenv for client side and server side development, and is a convenient way to use the same module (as an universal development).

Moreover, it is easier to manage and follow the evolution of this feature like that.

I've fixed tests coverage, It's up to you if this addition it is worth it

See ya !

@maxbeatty maxbeatty closed this Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants