First PR

[yTakkar]

Introduced ES6 syntax to JS files.
And some minor changes in installation command and other projects' list of README.md.

[zenflow]

This module currently supports node version 4, which does not support ES6 syntax (without the --harmony flag) so I think this can't be merged right now.

But node version 4 reaches End-Of-Life on 2018-04-30. So maybe then we can stop supporting node version 4 too, and switch to ES6 syntax.

[zenflow]

@yTakkar I suggest breaking up this PR into separate PRs

[yTakkar]

@zenflow I think you're right, I should break up this PR into separate PRs

[zenflow]

@yTakkar Maybe open 3 fresh PRs rather than undoing changes here, so it's easier to review

[maxbeatty]

👋 thanks for contributing! We've found more success in the past when someone creates an issue with a suggestion for a change; a majority of people agree on it, and then a Pull Request is created.

[zenflow]

@maxbeatty Yeah, that approach is usually better, but for simple changes like f1cd386 it's easier and faster and makes more sense to suggest the change and discuss it in a PR, right?

[zenflow]

I think the reason it's better to discuss non-trivial changes in an issue first is because it could be rejected and then your time coding the changes was wasted.

[yTakkar]

But what if someone suggests any change and there's no issue about that change??
I mean PRs will never be accepted/merged if it doesn't have any related issue??

[yTakkar]

I'll suggest merging it, after all it's a transition of code to es6 onyl!!

[maxbeatty]

To minimize wasted effort, make sure your change is wanted before spending time on it. Issues are a good way to do that. Well-written Pull Request descriptions are another way.

Today, I do not see enough benefit to accept these changes. If in the future new syntax results in a performance gain, safer execution, or similar improvement, I would be open to updating it.

[zenflow]

I mean PRs will never be accepted/merged if it doesn't have any related issue??

I think there are exceptions. See my comment #281 (comment). I don't know if @maxbeatty agrees because he didn't reply to me.