Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template builds inappropriate resources into zip by misapplying lists of downstream resources #12

Closed
StoneCypher opened this issue Apr 26, 2017 · 6 comments

Comments

@StoneCypher
Copy link
Contributor

Default project builds dependencies of node-lambda into lambda zipfile. Hello world now carries commander, graceful-readlink, sax, xml2js, xmlbuilder, etc. ~771k of deps.

New project maintainer closed the original #4 because he misunderstands it. I was trying to explain but he locked the issue because I asked him to not close it.

The actual problem is not that node-lambda builds things in because they're in use; it's that node-lambda-template is incorrectly propositioning its own tools as part of the downstream build.

This is a problem in the template, despite that the new maintainer closed an issue while the issue's creator was trying to explain what they misunderstood.

@motdotla - please help with the overly aggressive new issue burying mod, thanks

@StoneCypher StoneCypher changed the title Default project builds dependencies of node-lambda into lambda zipfile. Hello world now carries commander, graceful-readlink, sax, xml2js, xmlbuilder, etc. ~771k of deps. Template builds inappropriate resources into zip by misapplying lists of downstream resources Apr 26, 2017
@StoneCypher
Copy link
Contributor Author

Unfortunately new maintainer is using issue locking when someone says "please don't close things that aren't fixed just because you don't want to learn about them"

I guess this isn't a safe project for me anymore

@DeviaVir
Copy link
Collaborator

To me, your request is still very vague, but I would like clear visibility on the issue you've apparently identified.

Just to confirm, the change you would like to see is node-lambda removed as a dependency from the package.json, and instead inform the user to do an npm install -g node-lambda and run the commands using the global bin vs. having it use the node-modules here?

If my assumption above is incorrect, please add a concise and clear description of the problem.

@StoneCypher
Copy link
Contributor Author

I'm not sure what you find vague, unclear or imprecise about "you're building things into the deployed bundle that the deployed bundle doesn't want or need"

  1. Make a hello, world
  2. Build the hello, world
  3. Notice that inside the package to be deployed to lambda, there are references to things not used by the hello, world
  4. Notice that this is a direct result of the way the template sets up the parent library

The problem is not in the outside. It is that the built package is listing the build tools as dependencies.

The thing that goes to lambda does not have any need of node-lambda

@DeviaVir
Copy link
Collaborator

DeviaVir commented May 1, 2017

resolved in #14

@DeviaVir DeviaVir closed this as completed May 1, 2017
@StoneCypher
Copy link
Contributor Author

thank you

@DeviaVir
Copy link
Collaborator

DeviaVir commented May 2, 2017

@StoneCypher no, thank you. I apologise for the way I handled your first ticket and am very happy you were persistent with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants