Add a dummy CVS backend to recognize and skip CVS working directories #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Songmu
added a commit
that referenced
this pull request
Apr 27, 2019
## [v0.10.0](v0.9.0...v0.10.0) (2019-04-27) * drop mitchellh/go-homedir dependency [#122](#122) ([Songmu](https://github.com/Songmu)) * introduce Go Modules and adjust releng files [#121](#121) ([Songmu](https://github.com/Songmu)) * Add a dummy CVS backend to recognize and skip CVS working directories [#115](#115) ([knu](https://github.com/knu)) * add -l option on get command which immediately look after get [#112](#112) ([kuboon](https://github.com/kuboon)) * add support for Fossil SCM [#98](#98) ([motemen](https://github.com/motemen)) * Use parsed username also with ssh for Git [#101](#101) ([jjv](https://github.com/jjv)) * Add ghq.completeUser config to disable user completion of `ghq get` [#118](#118) ([k0kubun](https://github.com/k0kubun)) * ghq get --vcs=<vcs> [#72](#72) ([motemen](https://github.com/motemen)) * warn if executable was not found when RunCommand [#70](#70) ([motemen](https://github.com/motemen)) * support `meta name="go-import"` to detect Go repository [#120](#120) ([Songmu](https://github.com/Songmu)) * support refs which start with URL Authority in ghq get [#119](#119) ([Songmu](https://github.com/Songmu))
|
FYI; My ghq.root is ghq-v0.9.0 list returns the below; However, ghq-v0.10.0 list returns only When I renamed |
|
@masutaka That is an unfortunate problem with a case insensitive filesystem. It's too bad there is no way to get the exact file name written on disk via os.Stat(); Name() of FileInfo just returns what was passed to os.Stat(). I guess the only way to perform a case sensitive match is to open the parent directory and iterate through the directory entries. |
knu
added a commit
to knu/ghq
that referenced
this pull request
May 1, 2019
Since `os.Stat("CVS")` successfully picks `cvs` on a case insensitive
filesystem, we need to iterate through the directory entries to see if
the directory with the exact name exists.
cf. x-motemen#115 (comment)
knu
added a commit
to knu/ghq
that referenced
this pull request
May 1, 2019
Since `os.Stat("CVS")` successfully picks `cvs` on a case insensitive
filesystem, we need to iterate through directory entries to see if a
directory with the exact name exists.
cf. x-motemen#115 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a CVS working directory tree in ghq.root, ghq walks into it and never gets out until it traverses the whole tree.
CVS does not have a single URL which it can clone from, but you need a pair of a CVSROOT URL and a module path which can include any level of relative directory components. That's why I gave up on implementing real Clone()/Update() functions.
To wrap up, this patch teaches ghq to just keep away from CVS working trees.