Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Component Updates #103

Merged
merged 9 commits into from
Aug 12, 2017
Merged

Button Component Updates #103

merged 9 commits into from
Aug 12, 2017

Conversation

stevenyuen
Copy link
Contributor

@stevenyuen stevenyuen commented May 31, 2017

  • Button size prop is responsive
  • Improve UI for translucent mode
  • Improve UI for plain mode

@stevenyuen stevenyuen self-assigned this May 31, 2017
@stevenyuen stevenyuen changed the base branch from master to 1.8.0 May 31, 2017 21:45
Copy link
Member

@asabhaney asabhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool beans. Should the props plain and translucent be mentioned in the docs (unless they are already and I missed it)?

@asabhaney
Copy link
Member

asabhaney commented Aug 1, 2017

@stevenyuen one other small thing I noticed. The link prop on Button seems to change the styling of a button. See screenshots:

With link prop:

screen shot 2017-08-01 at 10 37 29 am

Without link prop:

screen shot 2017-08-01 at 10 37 38 am

…ops. Also updated Button component to use OIO container fontFamily. Fixed issue with Button in ButtonGropu with mode list
@stevenyuen
Copy link
Contributor Author

@asabhaney fixed the issues you mentioned. Pushed an update that:

  • Updates docs for button component to include plain and translucent props
  • Updated Button component to use OIO container fontFamily
  • Fixed issue with Button in ButtonGroup with mode list

@asabhaney
Copy link
Member

@stevenyuen cool. any reason that translucent, plain and outline aren't one prop? Are they not an enum?

@stevenyuen
Copy link
Contributor Author

@asabhaney yeah the way it is set up right now it probably should be one prop. I guess the reason it isn't one prop is that I've been wanting revamp how those style settings right now work - which I think will change how those different props work together. i.e.. translucent might not actually be a setting, we might instead just have an 'opacity' or 'transparency' type prop on the button (so you could achieve that effect or change the transparent on say a 'outline' button. Likewise, I've always felt like plain is kinda a dumb name and doesn't work very well as of right now.

@asabhaney asabhaney merged commit f224709 into 1.8.0 Aug 12, 2017
@asabhaney asabhaney deleted the button branch August 12, 2017 18:07
asabhaney added a commit that referenced this pull request Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants