-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button Component Updates #103
Conversation
stevenyuen
commented
May 31, 2017
•
edited
Loading
edited
- Button size prop is responsive
- Improve UI for translucent mode
- Improve UI for plain mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool beans. Should the props plain
and translucent
be mentioned in the docs (unless they are already and I missed it)?
@stevenyuen one other small thing I noticed. The With Without |
…ops. Also updated Button component to use OIO container fontFamily. Fixed issue with Button in ButtonGropu with mode list
@asabhaney fixed the issues you mentioned. Pushed an update that:
|
@stevenyuen cool. any reason that |
@asabhaney yeah the way it is set up right now it probably should be one prop. I guess the reason it isn't one prop is that I've been wanting revamp how those style settings right now work - which I think will change how those different props work together. i.e.. translucent might not actually be a setting, we might instead just have an ' |