Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form Components updates (merge #112 first) #111

Closed
wants to merge 2 commits into from
Closed

Form Components updates (merge #112 first) #111

wants to merge 2 commits into from

Conversation

stevenyuen
Copy link
Contributor

  • Added small size to select form input

asabhaney
asabhaney reviewed Aug 11, 2017
View reviewed changes
Copy link
Member

@asabhaney asabhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey looks good. Just wondering if there should be a large size, and also a default size. What do you think?

@stevenyuen
Copy link
Contributor Author

@asabhaney yeah sorry actually wasn't finished this PR. I was going to maybe give this size prop to all form components

@stevenyuen stevenyuen changed the title Form Components updates Form Components updates (merge #112 first) Aug 30, 2017
@asabhaney asabhaney changed the base branch from 1.8.0 to 1.9.0 October 25, 2017 20:09
@stevenyuen stevenyuen closed this Mar 21, 2018
@stevenyuen stevenyuen deleted the forms branch March 21, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asabhaney asabhaney asabhaney left review comments

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenyuen @asabhaney