OIO Defaults #38
OIO Defaults #38
Conversation
| import style from './style.less' | ||
|
|
||
| // TODO: Deprecate fontFamily and primaryColor props |
There was a problem hiding this comment.
@stevenyuen Any reason not to deprecate primaryColor and fontFamily in this PR? (At least internally)
There was a problem hiding this comment.
@asabhaney just would prefer to do that in a separate PR since lots of components use that primaryColor prop.
There was a problem hiding this comment.
Sounds good. I'll this as an issue.
| import style from './style.less' | ||
|
|
||
| // TODO: Deprecate fontFamily and primaryColor props |
There was a problem hiding this comment.
Sounds good. I'll this as an issue.
| } | ||
| }, | ||
| viewport: { | ||
| minSizes: { |
There was a problem hiding this comment.
Was just thinking, how do you feel about using the word breakpoints? Just an idea
There was a problem hiding this comment.
@asabhaney good idea.
| b: '768px', | ||
| c: '992px', | ||
| d: '1300px', | ||
| e: '1650px' |
There was a problem hiding this comment.
I'm guessing this is using characters instead of numbers because of our breakpoint system that uses the 2[b-e] style syntax?
There was a problem hiding this comment.
Exactly. Right on sir.
| @@ -12,7 +14,8 @@ export default class OIO extends Component { | |||
|
|
|||
| static defaultProps = { | |||
| fontFamily: 'Helvetica Neue, Arial', | |||
| primaryColor: '#78909C' | |||
| primaryColor: '#78909C', | |||
| ...defaults | |||
No description provided.