Popover additions #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevenyuen
commented
Jan 23, 2017
stevenyuen
commented
- Added support for above and below positions
asabhaney
reviewed
Jan 31, 2017
|
|
||
| this.hide = this.hide.bind(this) | ||
|
|
||
| // Eventually allow smart positioning and below/above | ||
| this.show = this.show.bind(this) |
asabhaney
reviewed
Jan 31, 2017
src/components/Popover/index.js
Outdated
| @@ -38,13 +41,14 @@ export default class Popover extends Component { | |||
| } | |||
|
|
|||
| show(event) { | |||
| event.stopPropagation() | |||
| const button = event | |||
asabhaney
approved these changes
Jan 31, 2017
|
@stevenyuen Flipping this back to you (made some changes). If you're happy with my changes, feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.