Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageInput component #53

Merged
merged 9 commits into from
Feb 3, 2017
Merged

ImageInput component #53

merged 9 commits into from
Feb 3, 2017

Conversation

stevenyuen
Copy link
Contributor

  • Image File Dropzone
  • Basically separated FileInput into 2 separate components (FileInput and ImageInput)

@stevenyuen stevenyuen changed the base branch from master to 1.5.0 February 1, 2017 00:39
@stevenyuen stevenyuen self-assigned this Feb 1, 2017
asabhaney
asabhaney requested changes Feb 3, 2017
View reviewed changes
Copy link
Member

@asabhaney asabhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredreich I just noticed that handleError is being used here and here, but it is not defined anywhere. Do you mind fixing this?

jaredreich
jaredreich approved these changes Feb 3, 2017
View reviewed changes
Copy link
Contributor

@jaredreich jaredreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just would recommend to have demo/content/Form.js updated to match these changes. Another option is to flesh out demo/content/Form.js as a proper demo page in a different PR.

@jaredreich
Copy link
Contributor

@asabhaney Applied the fixes for the handleError's here: 9e78290

Also, updated demo/content/Form.js to accommodate ImageInput

@stevenyuen sorry to add to your PR, remember to git pull this branch before going on

@asabhaney
Copy link
Member

Thanks @jaredreich!

@asabhaney asabhaney merged commit fc8679b into 1.5.0 Feb 3, 2017
@asabhaney asabhaney deleted the file-input-image branch February 3, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredreich jaredreich jaredreich approved these changes

@asabhaney asabhaney asabhaney approved these changes

Assignees

@stevenyuen stevenyuen

@jaredreich jaredreich

Labels
in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenyuen @jaredreich @asabhaney